[New package] .NET 9 #6344
[New package] .NET 9 #6344
Conversation
Co-authored-by: hgy59 <[email protected]>
|
@brice-fromentin there is an issue with the file for the icon. The file is called dotnet.png but the content is jpeg. I have such an icon, but I can't push this to your PR. and when ignoring the warning, there is an error when pushing the branch because the reference is ambigous. The messages might be related to my git client (tortoise git), but I guess this is bad practice anyway and ask you to delete the tag. |
|
@hgy59 ok, use the dotnet8 runtime picture, and remove tag. |
|
@brice-fromentin what is the reason that you dropped the support for DSM 6? |
|
I successfully tested it on aarch64-6.2.4. If you don't mind I would like to add DSM 6 support. BTW: SynoCommunity packages offer a certain value for Diskstation models that are no longer supported by Synology. |
|
|
@hgy59 Thank you for your review and comments. I'll proceed with the merge later today unless any new issues are identified. |
as I don't expect release 9.0.1 before january '25, it is good to go. |
|
@mreid-tt one thing I was not able to test is, whether .net 9 works on DSM 7.1. My single system with DSM 7.1.1 is armada370 that is not supported for dotnet. I have no idea whether this is related to armada370 or DSM 7.1.1. But if (and only if) we get feedback that it does not run on DSM 7.1.1, we will have a special challenge. So far we cannot enable a package for DSM 6 and limit it to DSM 7.2 for DSM > 7. |
|
@hgy59, no problem. I'll fire up a DSM 7.1.1 test on my DS916+ VM and let you know. What is the recommended method to test .NET? |
happy you are asking this ❤️ The simple test that showed the error above was To test whether dotnet9 runtime works without my current test program looks like this: using System;
namespace CultureInfoTest
{
class Program
{
static void Main(string[] args)
{
// Test if we can successfully create several culture info
PrintCultureInfo("en-US");
PrintCultureInfo("de-CH");
PrintCultureInfo("fr-CH");
PrintCultureInfo("it-CH");
PrintCultureInfo("el-EL");
PrintCultureInfo("pt-PT");
PrintCultureInfo("pt-BR");
}
static void PrintCultureInfo(string culture)
{
try
{
var info = new System.Globalization.CultureInfo(culture);
Console.WriteLine($"CultureInfo [{info.Name}]:");
Console.WriteLine("------------------------------");
Console.WriteLine($"NativeName: {info.NativeName}");
Console.WriteLine($"DisplayName: {info.DisplayName}");
Console.WriteLine($"EnglishName: {info.EnglishName}");
Console.WriteLine($"IsNeutralCulture: {info.IsNeutralCulture}");
Console.WriteLine($"LCID: {info.LCID}");
Console.WriteLine($"DateTimeFormat.NativeCalendarName: {info.DateTimeFormat.NativeCalendarName}");
Console.WriteLine($"DateTimeFormat.DayNames: {string.Join(",", info.DateTimeFormat.DayNames)}");
Console.WriteLine($"DateTimeFormat.MonthNames: {string.Join(",", info.DateTimeFormat.MonthNames)}");
Console.WriteLine();
}
catch (Exception ex)
{
Console.WriteLine($"ERROR: failed to create CultureInfo [{culture}], Error [{ex.Message}]");
}
}
}
}To create an executable, that you can run on the Diskstation, you need the dotnet9-sdk
My intention was to test culture info for all languages available under DSM, so it is not completed yet. You find the two files in the attachment here: |
|
@hgy59, thanks for the detailed response. All checks seem to work well: |
|
@mreid-tt looks good. can you run My Systems show: DSM 7.1.1 (DS-115j) DSM 6.2.4 (DS-218) |
|
@hgy59, as requested: |
mreid-tt
added
the
status/published
* Initial release. * Change picture to use the dotnet8 package one. * add support for DSM 6 --------- Co-authored-by: Brice FROMENTIN <[email protected]> Co-authored-by: hgy59 <[email protected]>
Description
Initial release of .NET 9 package for DSM 7.0+ (and DSM 6).
Closes #6343
Checklist
all-supportedcompleted successfullyType of change